Upate Observatorium API to get latest improvements #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update aims to simplify Observatorium APIs configuration surface.
Breaking changes:
* Observatorium API Thanos Querier serving only UI assets is obsolete
* --metrics.ui.endpoint was removed
* --metrics.read.endpoint takes the root path and appends
/api/v1/{query/query_range}
* --metrics.write.endpoint takes the root path and appends
/api/v1/receive
* Updates from Observatorium API configuration (Port for internal
server, healthcheck improvements)
squat
previously approved these changes
May 12, 2020
squat
approved these changes
May 12, 2020
|
Nice additions to the Makefile! |
brancz
approved these changes
May 13, 2020
| #!/bin/bash | ||
| # This is a placeholder file needed by the CI/CD templates | ||
| # You can safely ignore this file :) | ||
| exit 0 |
There was a problem hiding this comment.
are you sure this should be removed? last time I talked to @aditya-konarde he mentioned that this is still needed by the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update aims to simplify Observatorium APIs configuration surface.
Breaking changes:
--metrics.ui.endpointwas removed--metrics.read.endpointtakes the root path and appends/api/v1/{query/query_range}--metrics.write.endpointtakes the root path and appends/api/v1/receiveAs I was touching all manifests and its jsonnet I took some minutes to add some proper Makefile targets that will only rebuild, if dependent files change.
/cc @squat @brancz @kakkoyun @krasi-georgiev
As we cover the Operator in e2e tests and I actually tried it on a local kind cluster, I don't expect any breaking changes from this for the Operator itself. /cc @rollandf @nmagnezi