Fix support for resolvers on input types in single file mode… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17831957868Details
💛 - Coveralls |
obs-gh-christiannester
changed the title
obs-gh-christiannester
force-pushed
the
fix_input_type_handling
branch
from
645d72d to
afcd531
Compare
georgios-observeinc
requested changes
Sep 18, 2025
plugin/resolvergen/resolver.go
Outdated
| } | ||
|
|
||
| for _, o := range data.Objects { | ||
| objects := make(codegen.Objects, len(data.Objects)+len(data.Inputs)) |
Collaborator
There was a problem hiding this comment.
Why do we need to copy?
Doesn't the following work?
for _, o := range append(data.Objects, data.Inputs...) {
Collaborator
Author
There was a problem hiding this comment.
That works as well. Changed it.
obs-gh-christiannester
force-pushed
the
fix_input_type_handling
branch
from
afcd531 to
ca1adfc
Compare
georgios-observeinc
approved these changes
Sep 18, 2025
georgios-observeinc
pushed a commit
that referenced
this pull request
Sep 18, 2025
…esolver plugin (#8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in the resolver plugin
gqlgen's resolver plugin does not handle input types with resolvers correctly when generating
only a single output file. This change fixes that.
It was doing it correctly in the follow-schema mode.
I have: