fix(cloudwatch_metrics): correct rule schedule expression #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schedule previously ran once an hour. I tested 1 minute, 5 minutes, and 3 hours
jta
approved these changes
Mar 11, 2023
luke-zhu
changed the title
jta
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR #62 fixed our schedule expression to fire at the correct cadence, but subtly changed the time at which the rule would trigger. The use of the `rate` function ensures a rule will trigger at regular intervals from rule creation. Given the nature of the data we are collecting, we want rules to trigger aligned to fixed time boundaries (e.g. every minute, every hour). This commit reintroduces a correct cron expression.
jta
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR #62 fixed our schedule expression to fire at the correct cadence, but subtly changed the time at which the rule would trigger. The use of the `rate` function ensures a rule will trigger at regular intervals from rule creation. Given the nature of the data we are collecting, we want rules to trigger aligned to fixed time boundaries (e.g. every minute, every hour). This commit reintroduces a correct cron expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The schedule previously ran once an hour. It now should do what the interval variable says it does
Testing
I tested 1 minute, 5 minutes, and 3 hours