feat: select runtime / arch based off version #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.tf
Outdated
| s3_bucket = var.s3_bucket != "" ? var.s3_bucket : lookup(var.s3_regional_buckets, data.aws_region.current.name, local.default_lambda_bucket) | ||
| s3_key = var.s3_key != "" ? var.s3_key : join("/", [var.s3_key_prefix, format("%s.zip", var.lambda_version)]) | ||
|
|
||
| goarch = lookup({ |
There was a problem hiding this comment.
okay so, logicking through the lookup() and current default lambda_version ("latest"), this will always fall through to the default go1.x unless we explicitly override lambda_version. sgtm
obs-gh-irismcleary
approved these changes
Jun 22, 2023
bendrucker
reviewed
Jun 22, 2023
Contributor
bendrucker
left a comment
bendrucker
left a comment
There was a problem hiding this comment.
There's a syntax error here
Contributor
|
Actually no just weird indentation |
bendrucker
approved these changes
Jun 22, 2023
Author
I was really surprised by the result of Edit: the trick was not having the opening |
We provide newer builds that can run on `provided.al2` for different architectures. These builds are under a GOARCH directory (e.g. `arm64/latest`). This commit identifies what runtime, handler and architecture to use based off of the version string. Will defer switching the default for `lambda_version` to a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide newer builds that can run on
provided.al2for different architectures. These builds are under a GOARCH directory (e.g.arm64/latest). This commit identifies what runtime, handler and architecture to use based off of the version string.Will defer switching the default for
lambda_versionto a future release.