fix: address snapshot race #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to ensure we only invoke the snapshot lambda once we have the appropriate permission. Since we depend on the eventbridge target, we should ensure the target is only installed after the lambda permission has been configured. We also update the version constraint on `aws` to reflect the use of `aws_lambda_invocation` which was only introduced in 3.72.0
obs-gh-colinhutchinson
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure we only invoke the snapshot lambda once we have the appropriate permission. Since we depend on the eventbridge target, we should ensure the target is only installed after the lambda permission has been configured.
We also update the version constraint on
awsto reflect the use ofaws_lambda_invocationwhich was only introduced in 3.72.0