feat: add log_group_name output
#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
approved these changes
Jul 24, 2023
bendrucker
force-pushed
the
output-cw-log-group
branch
from
2762e1c to
0f616ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposes the CloudWatch log group name as an output.
Motivation
Allows callers of this module to wire up this log group with a filter to a Kinesis Firehose delivery stream, e.g.,:
https://github.com/observeinc/terraform-aws-kinesis-firehose/tree/main/modules/cloudwatch_logs_subscription
Currently, because the Lambda implicitly depends on this (even with #68), callers have to hardcode this
/aws/lambda/*pattern. We should encapsulate the hack here.Testing
terraform validateensures this reference is valid and is sufficient proof that this works.