Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Race condition streaming protocol parser #4

Open
3rd-Eden opened this Issue · 2 comments

1 participant

@3rd-Eden
Owner

The streaming protocol parser is failing randomly. It seems that the ProtocolStream#destroy is called to early before we could parse all the messages.

See: http://cl.ly/1i431h3m3C2G301y013H

@3rd-Eden
Owner

Failing travis-ci related to this issue: http://travis-ci.org/#!/observing/red/builds/740730 - it seems that ProtocolStream#destroy is called multiple times here.

@3rd-Eden
Owner

Patched multiple destroy calls with commit 30e7a14 with a boolean check, but we should double check if we cannot eliminate the multiple destroy calls.

Even if we solve this, the patch in the commit 30e7a14 should still stay to prevent double emits, like the net.js has: joyent/node@5e91042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.