From 92cc33a6e58c3cd132ead93d83cdc94a94dc15e2 Mon Sep 17 00:00:00 2001
From: Thomas Lokshall <thomas.lokshall@gmail.com>
Date: Sun, 23 Sep 2012 22:27:34 +0200
Subject: [PATCH] Fixes bug that causes certain browser to follow the # link on
 sorted columns

Some browsers will follow the "#" hyperlink generated by JHTML's
grid.sort command unless the javascript onclick returns false. This will
cause components with URLs that look like "index.php?option=com_example"
to redirect to "index.php#", effectively breaking sorting functions.
This affects at least frontend functions that use this in Joomla! 2.5.x
---
 libraries/joomla/html/grid.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/joomla/html/grid.php b/libraries/joomla/html/grid.php
index 6307f7a4a9..e759e5924b 100644
--- a/libraries/joomla/html/grid.php
+++ b/libraries/joomla/html/grid.php
@@ -86,7 +86,7 @@ public static function sort($title, $order, $direction = 'asc', $selected = 0, $
 			$direction = ($direction == 'desc') ? 'asc' : 'desc';
 		}
 
-		$html = '<a href="#" onclick="Joomla.tableOrdering(\'' . $order . '\',\'' . $direction . '\',\'' . $task . '\');" title="'
+		$html = '<a href="#" onclick="Joomla.tableOrdering(\'' . $order . '\',\'' . $direction . '\',\'' . $task . '\'); return false;" title="'
 			. JText::_('JGLOBAL_CLICK_TO_SORT_THIS_COLUMN') . '">';
 		$html .= JText::_($title);