Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix occasional incorrect images in user docs & plugin store. #779

Merged
merged 1 commit into from Jun 13, 2022

Conversation

claremacrae
Copy link
Collaborator

Description

The User Guide and README.md were showing images from the main branch, whereas the docs are published from the gh-pages branch.

This meant that if existing screenshots were updated on main, they would be shown in the documentation and community plugin store, prior to the new feature being released to users.

For consistency, I've opted for making all images shown in this repo from the gh-pages repo, including the README. This fixes the related problem that the Obsidian Community Plugin store was showing an image of a feature that has not yet been released.

Motivation

This fixes #778.

The User Guide and README.md were showing images from the main
branch, whereas the docs are published from the gh-pages branch.

This meant that if existing screenshots were updated on main, they would
be shown in the documentation and community plugin store, prior to the
new feature being released to users.

For consistency, I've opted for making all images shown in this repo
from the gh-pages repo, including the README. This fixes the related
problem that the Obsidian Community Plugin store was showing an image
of a feature that has not yet been released.
@claremacrae claremacrae merged commit 469e09b into main Jun 13, 2022
@claremacrae claremacrae deleted the docs-fix-content-and-image-mismatch branch June 13, 2022 15:31
@claremacrae claremacrae added the scope: documentation Improvements or additions to documentation label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation is showing images for features that are not yet released
1 participant