Add 'Focus Mode' plugin.

[ryanpcmcquen]

• I am submitting a new Community Plugin

Repo URL

https://github.com/ryanpcmcquen/obsidian_focus_mode

Release Checklist

• I have tested this on Windows

• I have tested this on macOS

• I have tested this on Linux

• Github release contains all required files

  • main.js
  • manifest.json
  • styles.css

• Github release name matches the exact version number specified in your manifest.json (Note: Use the exact version number, don't include a prefix v)

• The id in my manifest.json matches the id in the community-plugins.json file.

• README clearly describes the plugins purpose and provides clear usage instructions.

[ryanpcmcquen]

Oh wait, my release only contains main.ts, not main.js. Looks like the default .gitignore excludes it ... am I supposed to manually add that?

[lishid]

You should upload the built files to your Releases tab instead of pushing it into the repo - edit this release: https://github.com/ryanpcmcquen/obsidian_focus_mode/releases/tag/1.0.0

[ryanpcmcquen]

@lishid, thanks for the reply! Does it only need those 3 files?

[ryanpcmcquen]

Also, is there a naming convention for that? For instance, would this name work?

obsidian_focus_mode__1.0.0.zip

[ryanpcmcquen]

Oh, or is the expectation that I just manually include those files?

[lishid]

Yeah, check out how the other plugins do it in the releases section :)

[ryanpcmcquen]

@lishid, done!

[ryanpcmcquen]

@lishid or @ericaxu, anything else I can do on this to help? I don't have access to the other platforms now, but since the code here operates on the DOM, it should be universal.

[ryanpcmcquen]

Got access to a Windows machine and tested there, will try to find a Linux comp or user.

[ryanpcmcquen]

Tested on Linux (Kubuntu 20.04/AppImage 0.11.13):

[ryanpcmcquen]

Windows screenshot for posterity:

[lishid]

Ok, couple of small things:

• Rename your class from MyPlugin to your actual plugin name.
• https://github.com/ryanpcmcquen/obsidian_focus_mode/blob/4ee360ff69b51b4c95fa458c9895202285761d11/main.ts#L12
  This seems unused.
• https://github.com/ryanpcmcquen/obsidian_focus_mode/#development
  Clean up your README.md

[ryanpcmcquen]

@lishid thanks for the solid review! Done:
ryanpcmcquen/obsidian-focus-mode@fe47027

[lishid]

I've changed your plugin ID from using underscores to using dashes. Once you update them in your repo, I'll merge the PR 👍

[ryanpcmcquen]

@lishid done! Despite the fact that I love underscores, consistency should always win!