Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add obsidian-emoji-toolbar #72

Merged
merged 1 commit into from Nov 30, 2020
Merged

Add obsidian-emoji-toolbar #72

merged 1 commit into from Nov 30, 2020

Conversation

oliveryh
Copy link
Contributor

Hi Obsidian creators,

The following makes use of the current switcher to allow you to search for a insert emojis.

Let me know if you need any other changes before it can be accepted

@lishid
Copy link
Collaborator

lishid commented Nov 29, 2020

I got a 404 when opening your repo oliveryh/obsidian-emoji-toolbar. Maybe it's set to a private repo?

@oliveryh
Copy link
Contributor Author

My mistake. Made public now!

@lishid lishid merged commit 52b4a4b into obsidianmd:master Nov 30, 2020
@lishid
Copy link
Collaborator

lishid commented Nov 30, 2020

Weird that you have a .ts file but no type annotations. Might want to add them for proper type checks :)

@oliveryh
Copy link
Contributor Author

I'm new to TS but that is my next task :) Thanks for merging.

@lishid
Copy link
Collaborator

lishid commented Nov 30, 2020

Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@oliveryh @lishid