Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obsidian-koreader-sync to community plugins list #738

Merged
merged 3 commits into from Jan 23, 2022

Conversation

Edo78
Copy link
Contributor

@Edo78 Edo78 commented Jan 21, 2022

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Edo78/obsidian-koreader-sync

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@lishid
Copy link
Collaborator

@lishid lishid commented Jan 23, 2022

Please auto format your code, as it currently contains a mix of spaces and tabs for indentation.

https://github.com/Edo78/obsidian-koreader-sync/blob/2dd3e980f5d3e1f9989161e6ce97fad0e477c30a/src/main.ts#L42
Recommend using normalizePath from obsidian to normalize paths before they're passed to vault functions.

https://github.com/Edo78/obsidian-koreader-sync/blob/2dd3e980f5d3e1f9989161e6ce97fad0e477c30a/src/main.ts#L21
Suggest making this function a class method in case you decide to make it into a command in the future (which I totally recommend!)

@lishid lishid merged commit 7cdb63a into obsidianmd:master Jan 23, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants