Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win-capture: Draw cursor of actual size #1284

Closed
wants to merge 1 commit into from

Conversation

SuslikV
Copy link
Contributor

@SuslikV SuslikV commented May 6, 2018

When drawing cursor to window capture area - use actual resource width
and height instead of system metric values for icons.

Related issue: https://obsproject.com/forum/threads/cursor-capture.84507/

When drawing cursor to window capture area - use actual resource width
and height instead of system metric values for icons.
@SuslikV
Copy link
Contributor Author

SuslikV commented May 6, 2018

Animated cursors is out of scope in this PR. I think, it should be added as an option ("Allow animated cursors" or so).

@jp9000
Copy link
Member

jp9000 commented May 6, 2018

Make sure to include what the problem is or what it's fixing in the commit message in the future. For your commit message here, it just says "Draw cursor of actual size" and "use actual resource width
and height instead of system metric values for icons" with zero context as to what this is changing and why.

@jp9000 jp9000 closed this in a75724d May 6, 2018
@SuslikV
Copy link
Contributor Author

SuslikV commented May 6, 2018

@jp9000 , please, add more comments to the code in the future. Sometimes, it is hard to understand why you divide by 2 or what the code should do.

@SuslikV SuslikV deleted the patch-3 branch May 6, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants