Skip to content

libobs-opengl: Add support for border color#3795

Closed
Xaymar wants to merge 1 commit into
obsproject:masterfrom
Xaymar:pr-opengl-border-color
Closed

libobs-opengl: Add support for border color#3795
Xaymar wants to merge 1 commit into
obsproject:masterfrom
Xaymar:pr-opengl-border-color

Conversation

@Xaymar
Copy link
Copy Markdown

@Xaymar Xaymar commented Nov 28, 2020

Description

Adds support for the border color sampler setting to the OpenGL renderer, fixing a feature disparity between platforms. This resulted in Linux and MacOS getting a worse experience out of the box, instead of the same experience as Windows.

Fixes #3794 and StreamFX#245

Motivation and Context

StreamFX's SDF Effects rely on border color to work.

How Has This Been Tested?

SDF Effects were no longer broken as described here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2020
@alessionossa
Copy link
Copy Markdown

Any ETA when this will be merged?

@Xaymar

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libobs-opengl: gs_sampler_info->border_color is ignored

4 participants