UI: Fix source name edit textbox not accepting input on enter #7373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Enter key is connected to the
Edit
function and is handled by Qt with the highest priority in its key event handler. Alas the boolean return value is not propagated to the shortcut handling system, so the key event will always be consumed and as such the user will be stuck in editing state.To fix this,
Edit
needs to behave like a toggle, saving the current state of the input at a repeat press of Enter while in editing state.Motivation and Context
Fixes #7240
How Has This Been Tested?
Tested on macOS, also tested that functionality is not impacted on Windows 11 and Ubuntu 22.
Types of changes
Checklist: