Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-ffmpeg: Increase initial buffer fullness for VAAPI #9179

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

nowrep
Copy link
Contributor

@nowrep nowrep commented Jun 30, 2023

Default ffmpeg initial buffer fullness (75%) is too low and results in significantly lower video quality on AMD cards.

Changing it to 100% fixes the quality and also matches what AMF encoder is doing.

Description

Set HRD initial buffer fullness to 100% to fix video quality on AMD cards.

Motivation and Context

Encoded video quality on AMD cards is rather bad with default settings at low bitrates (6000kbps).

How Has This Been Tested?

Tested on ArchLinux with mesa 23.1.3 and 7900XTX.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@nowrep nowrep force-pushed the vaapi-occupancy branch 2 times, most recently from d8f4a89 to 19d24f5 Compare June 30, 2023 05:52
Default ffmpeg initial buffer fullness (75%) is too low
and results in significantly lower video quality on AMD cards.

Changing it to 100% fixes the quality and also matches what
AMF encoder is doing.
@WizardCM WizardCM added Enhancement Improvement to existing functionality Linux Affects Linux labels Jul 1, 2023
@Lain-B Lain-B merged commit 5fdda17 into obsproject:master Jul 8, 2023
9 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Release) milestone Aug 10, 2023
@nowrep nowrep deleted the vaapi-occupancy branch April 21, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality Linux Affects Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants