New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic import rerouting, deprecated methods, etc #1276

Merged
merged 8 commits into from Mar 12, 2016

Conversation

Projects
None yet
4 participants
@megies
Member

megies commented Feb 20, 2016

It's time to get rid of all this dynamic import rerouting, deprecated methods, etcpp.

See #842, #999, #1039, #1246.

(-3530 lines ;-))

@megies megies added this to the 1.1.0 milestone Feb 20, 2016

@megies megies changed the title from Cleanup deprecation reroute etc to Remove dynamic import rerouting, deprecated methods, etc Feb 20, 2016

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 20, 2016

Member

So much work and now its all gone again ;-) But YES! Get rid of that stuff!

Member

krischer commented Feb 20, 2016

So much work and now its all gone again ;-) But YES! Get rid of that stuff!

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 20, 2016

Member

Might also be a new record in files changes per commit ^^

Member

krischer commented Feb 20, 2016

Might also be a new record in files changes per commit ^^

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Feb 20, 2016

Member

Not sure what this means: https://travis-ci.org/obspy/obspy/jobs/110591352#L654-L679

(taup/taup.py was removed)
screenshot from 2016-02-20 16 27 03

Member

megies commented Feb 20, 2016

Not sure what this means: https://travis-ci.org/obspy/obspy/jobs/110591352#L654-L679

(taup/taup.py was removed)
screenshot from 2016-02-20 16 27 03

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 20, 2016

Member

There was still a reference to the old taup wrapper in the __init__.py. I removed it as well as the test for the wrapper.

Member

krischer commented Feb 20, 2016

There was still a reference to the old taup wrapper in the __init__.py. I removed it as well as the test for the wrapper.

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic Feb 20, 2016

Member

We don't really have a simple replacement for those two TauP functions. Also, don't forget the documentation; there are definitely some gallery examples of it.

Member

QuLogic commented Feb 20, 2016

We don't really have a simple replacement for those two TauP functions. Also, don't forget the documentation; there are definitely some gallery examples of it.

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 20, 2016

Member

I don't think anybody should use the getTravelTimes() function. But yes - we should add a replacement picture to the gallery.

Member

krischer commented Feb 20, 2016

I don't think anybody should use the getTravelTimes() function. But yes - we should add a replacement picture to the gallery.

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic Feb 20, 2016

Member

Yea, that's fine actually, but the travelTimePlot seems nice anyway.

Member

QuLogic commented Feb 20, 2016

Yea, that's fine actually, but the travelTimePlot seems nice anyway.

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 20, 2016

Member

True. Let's rename it and but it somewhere else.

Member

krischer commented Feb 20, 2016

True. Let's rename it and but it somewhere else.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 1, 2016

Member

Rebased + force-pushed.

Member

megies commented Mar 1, 2016

Rebased + force-pushed.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 1, 2016

Member

True. Let's rename it and but it somewhere else.

Anything that still needs to be done here @krischer?

Member

megies commented Mar 1, 2016

True. Let's rename it and but it somewhere else.

Anything that still needs to be done here @krischer?

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Mar 1, 2016

Member

Yes I still have a number of things. I'm a bit short on time right now but I'll try to get it done this week.

Member

krischer commented Mar 1, 2016

Yes I still have a number of things. I'm a bit short on time right now but I'll try to get it done this week.

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Mar 2, 2016

Member

Done. If CI passes it can IMHO be merged.

Member

krischer commented Mar 2, 2016

Done. If CI passes it can IMHO be merged.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 2, 2016

Member

What about the discussion around getTravelTimes and travelTimePlot? Any TODOs left there?

Member

megies commented Mar 2, 2016

What about the discussion around getTravelTimes and travelTimePlot? Any TODOs left there?

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 11, 2016

Member

Rebased + force-pushed

Member

megies commented Mar 11, 2016

Rebased + force-pushed

megies added a commit that referenced this pull request Mar 12, 2016

Merge pull request #1276 from obspy/cleanup_deprecation_reroute_etc
Remove dynamic import rerouting, deprecated methods,  etc

@megies megies merged commit 4bf9901 into master Mar 12, 2016

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@megies megies deleted the cleanup_deprecation_reroute_etc branch Mar 12, 2016

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic Mar 13, 2016

Member

I'm not sure the travelTimePlot was restored?

Member

QuLogic commented Mar 13, 2016

I'm not sure the travelTimePlot was restored?

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 13, 2016

Member

Uhm, sorry, thought everything was good to go..

Member

megies commented Mar 13, 2016

Uhm, sorry, thought everything was good to go..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment