New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obspy/clients/fdsn/__init__.py #1282

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@nikosT
Contributor

nikosT commented Feb 22, 2016

Adding NOA fdsn web service

Update __init__.py
Adding NOA fdsn web service

@nikosT nikosT changed the title from Update __init__.py to Update clients/fdsn/__init__.py Feb 22, 2016

@nikosT nikosT changed the title from Update clients/fdsn/__init__.py to Update obspy/clients/fdsn/__init__.py Feb 22, 2016

@nikosT

This comment has been minimized.

Show comment
Hide comment
@nikosT

nikosT Feb 22, 2016

Contributor

I had forked the ObsPy repository, and add NOA line to obspy/clients/fdsn/init.py file. I'm not sure though if my fork had the latest obspy/clients/fdsn/init.py file. Can you check?

Contributor

nikosT commented Feb 22, 2016

I had forked the ObsPy repository, and add NOA line to obspy/clients/fdsn/init.py file. I'm not sure though if my fork had the latest obspy/clients/fdsn/init.py file. Can you check?

@petrrr

This comment has been minimized.

Show comment
Hide comment
@petrrr

petrrr Feb 22, 2016

Contributor

Hi Nicos, that's not the right place to add the data center abbreviations. You just changed the doc string. Please have a look at the header.py sources. It should be quite obvious where to put a new data center abbreviation.

Contributor

petrrr commented Feb 22, 2016

Hi Nicos, that's not the right place to add the data center abbreviations. You just changed the doc string. Please have a look at the header.py sources. It should be quite obvious where to put a new data center abbreviation.

@nikosT

This comment has been minimized.

Show comment
Hide comment
@nikosT

nikosT Feb 23, 2016

Contributor

You are right!

Contributor

nikosT commented Feb 23, 2016

You are right!

@nikosT nikosT closed this Feb 23, 2016

@nikosT

This comment has been minimized.

Show comment
Hide comment
@nikosT

nikosT Feb 23, 2016

Contributor

wrong pull_request

Contributor

nikosT commented Feb 23, 2016

wrong pull_request

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 23, 2016

Member

Please reopen this pull request. You need to change it in the doc and in the header.py.

Member

krischer commented Feb 23, 2016

Please reopen this pull request. You need to change it in the doc and in the header.py.

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Feb 23, 2016

Member

Just add one more commit to the branch.

Member

krischer commented Feb 23, 2016

Just add one more commit to the branch.

@nikosT

This comment has been minimized.

Show comment
Hide comment
@nikosT

nikosT Feb 23, 2016

Contributor

Actually, I had made a new one here: #1284
I apologize, since I didn't know how pull_requests work. So this pull and the one #1283 should be totally removed.

Remove: #1283, #1282
Accept: #1284

Contributor

nikosT commented Feb 23, 2016

Actually, I had made a new one here: #1284
I apologize, since I didn't know how pull_requests work. So this pull and the one #1283 should be totally removed.

Remove: #1283, #1282
Accept: #1284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment