Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add NNSA_KB_Core read support #1332
It looks like you based this PR on the current master correctly, but replaced some files with copies of your earlier PR so that some changes in those files are lost. I'll make separate notes on each of these problems that need fixing.
Also, it seems there are some changes of file permissions in there (making that file executable)? E.g... :
I think these executable flags should also be removed again.
Some flake8 (https://travis-ci.org/obspy/obspy/jobs/116477993#L700-L708) and then one test fail you should check: https://travis-ci.org/obspy/obspy/jobs/116477993#L690
Current coverage is
Apr 8, 2016
5 checks passed
Thanks for the contribution, good work there!
Btw.. now that this is merged you should ideally think about a