New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing UTCDateTime with other objects (float, int, UTCDateTime, datetime.datetime) #1670

Merged
merged 3 commits into from Mar 5, 2017

Conversation

Projects
None yet
2 participants
@barsch
Member

barsch commented Feb 13, 2017

see #1652 - those isinstance checks seem to influence performance not very much - no change in execution time for all core tests ...

@barsch barsch changed the title from fixes #1652 to Comparing UTCDateTime with other objects (float, int, UTCDateTime, datetime.datetime) Feb 13, 2017

@megies megies added this to the 1.1.0 milestone Feb 13, 2017

@megies megies added the .core label Feb 13, 2017

@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Feb 14, 2017

Member

why does it say: "docker-testbot — Docker tests failed" while all is green in details ?

Member

barsch commented Feb 14, 2017

why does it say: "docker-testbot — Docker tests failed" while all is green in details ?

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Feb 15, 2017

Member

why does it say: "docker-testbot — Docker tests failed" while all is green in details ?

The commit status is determined by the combined exit code of all docker containers while that link is just (trying to) match all of the sent reports from inside the containers. There's way less reports than there should be, could be test execution didn't get to the point of sending a failure report, or something else entirely went wrong. Hard to say.

There's no way to tell the docker bot to test that commit again (since there is already a commit status of the respective context -- and commit statuses can not be deleted), the only way to get a new build would be to push a new commit (can be an empty dummy commit of course).

Member

megies commented Feb 15, 2017

why does it say: "docker-testbot — Docker tests failed" while all is green in details ?

The commit status is determined by the combined exit code of all docker containers while that link is just (trying to) match all of the sent reports from inside the containers. There's way less reports than there should be, could be test execution didn't get to the point of sending a failure report, or something else entirely went wrong. Hard to say.

There's no way to tell the docker bot to test that commit again (since there is already a commit status of the respective context -- and commit statuses can not be deleted), the only way to get a new build would be to push a new commit (can be an empty dummy commit of course).

barsch added some commits Feb 13, 2017

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 5, 2017

Member

Rebased on current master and force-pushed. This should get rid of unrelated CI fails..

Member

megies commented Mar 5, 2017

Rebased on current master and force-pushed. This should get rid of unrelated CI fails..

@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Mar 5, 2017

Member

CI passes - merging

Member

barsch commented Mar 5, 2017

CI passes - merging

@barsch barsch merged commit 8bce327 into master Mar 5, 2017

8 of 9 checks passed

codecov/changes 6 files have unexpected coverage changes not visible in diff.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 87.58% (+1.55%) compared to 1e2e014
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-deb-buildbot Deb packaging and testing succeeded
Details
docker-testbot Docker tests succeeded
Details

@barsch barsch deleted the 1652 branch Mar 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment