New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master broken for older distros #1671

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
4 participants
@megies
Member

megies commented Mar 4, 2017

This commit dbf7368 on master breaks obspy on older distros. It was discovered because for some PRs (e.g. #1670) not all docker testbot containers are able to send test reports which leads to the confusing situation that docker testbot commit status is "red" while the corresponding link to test reports at tests.obspy.org shows only "green" reports (but way fewer than the docker testbot runs containers). Please fix @krischer and next time check out docker testbot status before merging.. ;-)

@megies megies added this to the 1.1.0 milestone Feb 15, 2017

@barsch barsch added the task label Feb 15, 2017

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Feb 15, 2017

Member

e.g. centos_7 container (run locally):

[...]
Successfully installed obspy
Cleaning up...
Looking up "https://pypi.python.org/pypi/pip/json" in the cache
Current age based on date: 11999586
Freshness lifetime from max-age: 600
The cached response is "stale" with no etag, purging
Starting new HTTPS connection (1): pypi.python.org
"GET /pypi/pip/json HTTP/1.1" 200 72982
Updating cache with response from "https://pypi.python.org/pypi/pip/json"
Caching b/c date exists and max-age > 0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Installation successful!
Traceback (most recent call last):
  File "/usr/bin/obspy-runtests", line 11, in <module>
    load_entry_point('obspy', 'console_scripts', 'obspy-runtests')()
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 567, in load_entry_point
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2604, in load_entry_point
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2264, in load
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2270, in resolve
  File "/obspy/obspy/__init__.py", line 39, in <module>
    from obspy.core.utcdatetime import UTCDateTime  # NOQA
  File "/obspy/obspy/core/__init__.py", line 119, in <module>
    from obspy.core.trace import Stats, Trace
  File "/obspy/obspy/core/trace.py", line 28, in <module>
    from obspy.core.util.decorator import raise_if_masked, skip_if_no_data
  File "/obspy/obspy/core/util/decorator.py", line 28, in <module>
    from decorator import decorator, decorate
ImportError: cannot import name decorate
Tests failed!
Done with everything!
[...]
Member

megies commented Feb 15, 2017

e.g. centos_7 container (run locally):

[...]
Successfully installed obspy
Cleaning up...
Looking up "https://pypi.python.org/pypi/pip/json" in the cache
Current age based on date: 11999586
Freshness lifetime from max-age: 600
The cached response is "stale" with no etag, purging
Starting new HTTPS connection (1): pypi.python.org
"GET /pypi/pip/json HTTP/1.1" 200 72982
Updating cache with response from "https://pypi.python.org/pypi/pip/json"
Caching b/c date exists and max-age > 0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Installation successful!
Traceback (most recent call last):
  File "/usr/bin/obspy-runtests", line 11, in <module>
    load_entry_point('obspy', 'console_scripts', 'obspy-runtests')()
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 567, in load_entry_point
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2604, in load_entry_point
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2264, in load
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2270, in resolve
  File "/obspy/obspy/__init__.py", line 39, in <module>
    from obspy.core.utcdatetime import UTCDateTime  # NOQA
  File "/obspy/obspy/core/__init__.py", line 119, in <module>
    from obspy.core.trace import Stats, Trace
  File "/obspy/obspy/core/trace.py", line 28, in <module>
    from obspy.core.util.decorator import raise_if_masked, skip_if_no_data
  File "/obspy/obspy/core/util/decorator.py", line 28, in <module>
    from decorator import decorator, decorate
ImportError: cannot import name decorate
Tests failed!
Done with everything!
[...]
@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Feb 15, 2017

Member

Btw, @krischer this is holding up other PRs (e.g. some by @barsch) because they don't get useful docker testbot results currently..

Member

megies commented Feb 15, 2017

Btw, @krischer this is holding up other PRs (e.g. some by @barsch) because they don't get useful docker testbot results currently..

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Feb 23, 2017

Member

Just stumbled over this one again, so ping @krischer, it's hampering other PRs..

Member

megies commented Feb 23, 2017

Just stumbled over this one again, so ping @krischer, it's hampering other PRs..

@Jollyfant

This comment has been minimized.

Show comment
Hide comment
@Jollyfant

Jollyfant Feb 23, 2017

Contributor

I think I ran in to this issue using ObsPy in Docker using Ubuntu 14.04. Needed to run:

RUN pip install decorator --upgrade
Contributor

Jollyfant commented Feb 23, 2017

I think I ran in to this issue using ObsPy in Docker using Ubuntu 14.04. Needed to run:

RUN pip install decorator --upgrade
@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Feb 23, 2017

Member

That works but for packaged distribution we are bound to the versions that are provided by the system packages.

Member

megies commented Feb 23, 2017

That works but for packaged distribution we are bound to the versions that are provided by the system packages.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 4, 2017

Member

Alright.. this should fix it hopefully. Please be more careful to not break our master @krischer.. (or at least fix it again 😜 )

Member

megies commented Mar 4, 2017

Alright.. this should fix it hopefully. Please be more careful to not break our master @krischer.. (or at least fix it again 😜 )

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 4, 2017

Member

All green, merging. (single travis fail is related to #1694)

Member

megies commented Mar 4, 2017

All green, merging. (single travis fail is related to #1694)

@megies megies merged commit 1e2e014 into master Mar 4, 2017

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/changes 6 files have unexpected coverage changes not visible in diff.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 87.57% (+1.54%) compared to ec99d8a
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
docker-testbot Docker tests succeeded
Details

@megies megies deleted the fix_decorate branch Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment