New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding short period 'SH' instruments to the default channel priorities #1687

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@krischer
Member

krischer commented Mar 1, 2017

As requested in this comment.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 22, 2017

Member

Rebased and force-pushed for new CI results..

Member

megies commented Mar 22, 2017

Rebased and force-pushed for new CI results..

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 22, 2017

Member

@seisman can you please have a look and comment on this PR?

Member

megies commented Mar 22, 2017

@seisman can you please have a look and comment on this PR?

@@ -199,7 +199,8 @@ def __init__(self, starttime, endtime,
"MH[ZNE12]", "EH[ZNE12]",
"LH[ZNE12]", "HL[ZNE12]",
"BL[ZNE12]", "ML[ZNE12]",
"EL[ZNE12]", "LL[ZNE12]"),
"EL[ZNE12]", "LL[ZNE12]",
"SH[ZNE12]"),

This comment has been minimized.

@seisman

seisman Mar 22, 2017

Contributor

Add SL[ZNE12] too?

@seisman

seisman Mar 22, 2017

Contributor

Add SL[ZNE12] too?

@@ -199,7 +199,8 @@ def __init__(self, starttime, endtime,
"MH[ZNE12]", "EH[ZNE12]",
"LH[ZNE12]", "HL[ZNE12]",
"BL[ZNE12]", "ML[ZNE12]",
"EL[ZNE12]", "LL[ZNE12]"),
"EL[ZNE12]", "LL[ZNE12]",
"SH[ZNE12]"),
location_priorities=("", "00", "10")):

This comment has been minimized.

@seisman

seisman Mar 22, 2017

Contributor

I think location_priorities should be extended to contain more values.

Location codes are usually random. People wouldn't known the exact location codes unless they request station metadata before requesting waveform data. Thus, most people, I presume, may prefer to leave the location parameter to None. In this case, location_priorities will determine which data should be downloaded.

Since location codes in current default location_priorities are incomplete, some data will be missed unexpectedly. For example, high gain (?H?) channels of YA network have location codes of 01 and 02. If I use the default location and location_priorities, I will get no data. See the link below for details about YA network.

http://service.iris.edu/fdsnws/station/1/query?net=YA&cha=?H?&level=channel&format=text&maxlat=54&minlon=65&maxlon=135&minlat=18&includecomments=true&nodata=404

My suggestion:

  1. add more common value to location_priorities, e.g., 01, 02, 06, 60...
  2. and wildcards [0-9][0-9], [0-9][A-Z] and [A-Z][0-9] as the last three items of location_priorities, to make sure that at least some data are downloaded if the channel codes fail to match other codes in location_priorities.

One reference which may be useful:

  1. https://ds.iris.edu/ds/newsletter/vol1/no1/specification-of-seismograms-the-location-identifier/
@seisman

seisman Mar 22, 2017

Contributor

I think location_priorities should be extended to contain more values.

Location codes are usually random. People wouldn't known the exact location codes unless they request station metadata before requesting waveform data. Thus, most people, I presume, may prefer to leave the location parameter to None. In this case, location_priorities will determine which data should be downloaded.

Since location codes in current default location_priorities are incomplete, some data will be missed unexpectedly. For example, high gain (?H?) channels of YA network have location codes of 01 and 02. If I use the default location and location_priorities, I will get no data. See the link below for details about YA network.

http://service.iris.edu/fdsnws/station/1/query?net=YA&cha=?H?&level=channel&format=text&maxlat=54&minlon=65&maxlon=135&minlat=18&includecomments=true&nodata=404

My suggestion:

  1. add more common value to location_priorities, e.g., 01, 02, 06, 60...
  2. and wildcards [0-9][0-9], [0-9][A-Z] and [A-Z][0-9] as the last three items of location_priorities, to make sure that at least some data are downloaded if the channel codes fail to match other codes in location_priorities.

One reference which may be useful:

  1. https://ds.iris.edu/ds/newsletter/vol1/no1/specification-of-seismograms-the-location-identifier/
@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 28, 2017

Member

Appveyor fail could be avoided by a rebase to current master.

Member

megies commented Mar 28, 2017

Appveyor fail could be avoided by a rebase to current master.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Jul 27, 2017

Member

This shouldn't be too hard to finalize, right? I'll leave it in for 1.1.0 but feel free to punt it to 1.2.0 @krischer .

Member

megies commented Jul 27, 2017

This shouldn't be too hard to finalize, right? I'll leave it in for 1.1.0 but feel free to punt it to 1.2.0 @krischer .

@trichter

This comment has been minimized.

Show comment
Hide comment
@trichter

trichter Aug 13, 2017

Member

Reference to similar issue #1810 (channels CL?).

Member

trichter commented Aug 13, 2017

Reference to similar issue #1810 (channels CL?).

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Oct 5, 2017

Member

Retriggered Appveyor. I will merge this as soon as it passes, anything else please everybody feel free to open a new PR for inclusion in 1.2.0.

Member

megies commented Oct 5, 2017

Retriggered Appveyor. I will merge this as soon as it passes, anything else please everybody feel free to open a new PR for inclusion in 1.2.0.

@megies megies merged commit db6336f into obspy:master Oct 5, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-deb-buildbot Deb packaging and testing succeeded
Details
docker-testbot Docker tests succeeded
Details

@megies megies deleted the krischer:fdsn-mass-downloader-channel-priorities branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment