New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise better error message if failing to create ResourceIdentifier #1699

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
2 participants
@krischer
Member

krischer commented Mar 6, 2017

http://lists.swapbytes.de/archives/obspy-users/2017-March/002313.html

We should raise a message that is more descriptive and tells people how to fix it.

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Mar 6, 2017

Member

This is now a PR.

Member

krischer commented Mar 6, 2017

This is now a PR.

@megies

megies approved these changes Mar 6, 2017

Very nice message!

@megies megies added this to the 1.1.0 milestone Mar 6, 2017

@krischer krischer merged commit 7e46425 into master Mar 6, 2017

7 of 8 checks passed

codecov/changes 6 files have unexpected coverage changes not visible in diff.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 87.59% (+1.55%) compared to 7fc054e
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-testbot Docker tests succeeded
Details

@krischer krischer deleted the res-id-better-err-msg branch Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment