New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes various small issues, typos, UserWarnings, deprecations, etc. #1700

Merged
merged 9 commits into from Mar 6, 2017

Conversation

Projects
None yet
3 participants
@barsch
Member

barsch commented Mar 6, 2017

someone was to fast merging the previous one ;)

@barsch barsch added the testing label Mar 6, 2017

@barsch barsch self-assigned this Mar 6, 2017

@barsch barsch added this to the 1.1.0 milestone Mar 6, 2017

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 6, 2017

Member

someone was to fast merging the previous one ;)

ooops, who could that be.. ;-)

btw.. better not push every single commit separaetly.. otherwise our Travis will be blocked for days on end.. (i've cancelled all intermediate Travis builds in this PR now)

Member

megies commented Mar 6, 2017

someone was to fast merging the previous one ;)

ooops, who could that be.. ;-)

btw.. better not push every single commit separaetly.. otherwise our Travis will be blocked for days on end.. (i've cancelled all intermediate Travis builds in this PR now)

@barsch barsch requested review from krischer and megies Mar 6, 2017

@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Mar 6, 2017

Member

imho ready to merge - dont feel like doing more :)

Member

barsch commented Mar 6, 2017

imho ready to merge - dont feel like doing more :)

@krischer

Looks good. Test output is also already much better! Thanks a lot!

One thing I noticed: Do the skipped reftek doctests have an equivalent test in the unittests? For the nordic file you added new unittests for the skipped doctests, but not for the reftek skips.

@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Mar 6, 2017

Member

@krischer: I didn't add an extra test just for the print(st[0].stats) part - "/path/to/225051000_00008656" is used multiple times in unittest as well as in doctest - so I didn't bother adding an extra test just for this basic functionalty - but if you insist I can add something

Member

barsch commented Mar 6, 2017

@krischer: I didn't add an extra test just for the print(st[0].stats) part - "/path/to/225051000_00008656" is used multiple times in unittest as well as in doctest - so I didn't bother adding an extra test just for this basic functionalty - but if you insist I can add something

@krischer krischer merged commit 77a6422 into master Mar 6, 2017

6 of 8 checks passed

codecov/changes 9 files have unexpected coverage changes not visible in diff.
Details
codecov/patch 87.7% of diff hit (target 90%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.64% (+1.6%) compared to 7fc054e
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-testbot Docker tests succeeded
Details

@krischer krischer deleted the various2 branch Mar 6, 2017

@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Mar 6, 2017

Member

we could move that print(st[0].stats) also down to the second part of the doctest - than it is covered too

Member

barsch commented Mar 6, 2017

we could move that print(st[0].stats) also down to the second part of the doctest - than it is covered too

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Mar 7, 2017

Member

Done in 3c8899e.

Member

krischer commented Mar 7, 2017

Done in 3c8899e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment