New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: fast fail builds if newer builds for the branch/PR are already queued #1713

Merged
merged 1 commit into from Mar 12, 2017

Conversation

Projects
None yet
4 participants
@megies
Member

megies commented Mar 12, 2017

This PR enables a strategy to reduce number of redundant Travis builds by reusing travis_fastfail.sh implemented by Julia developers.

@megies megies added the CI label Mar 12, 2017

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 12, 2017

Member

Works.. https://travis-ci.org/obspy/obspy/builds/210221363

(removed those dummy commits again that were used to test this PR: 690074a and 2486b48)

Member

megies commented Mar 12, 2017

Works.. https://travis-ci.org/obspy/obspy/builds/210221363

(removed those dummy commits again that were used to test this PR: 690074a and 2486b48)

@megies megies changed the title from Travis: fastfail and rolling build to Travis: fast fail builds if newer builds for the branch/PR are already queued Mar 12, 2017

Travis: skip outdated builds..
..to reduce amount of Travis builds and speed up CI
@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 12, 2017

Member

Good to merge.. I think.

Member

megies commented Mar 12, 2017

Good to merge.. I think.

@barsch

barsch approved these changes Mar 12, 2017

@megies megies merged commit 693e89a into master Mar 12, 2017

6 of 7 checks passed

codecov/changes 6 files have unexpected coverage changes not visible in diff.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 03c714f...64c429d
Details
codecov/project 87.57% (+1.54%) compared to 03c714f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-testbot Docker tests succeeded
Details

@megies megies deleted the travis_fastfail branch Mar 12, 2017

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic Mar 12, 2017

Member

Travis actually has fast-fail in beta; we're using it on Matplotlib. It's a bit buggy with already-running tests though.

Member

QuLogic commented Mar 12, 2017

Travis actually has fast-fail in beta; we're using it on Matplotlib. It's a bit buggy with already-running tests though.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 13, 2017

Member

Good to know, we should definitely switch once it goes out of beta (or maybe even now already?)

Member

megies commented Mar 13, 2017

Good to know, we should definitely switch once it goes out of beta (or maybe even now already?)

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Mar 13, 2017

Member

Good to know, we should definitely switch once it goes out of beta (or maybe even now already?)

I'd vote for switching right now - at least we won't forget then.

Member

krischer commented Mar 13, 2017

Good to know, we should definitely switch once it goes out of beta (or maybe even now already?)

I'd vote for switching right now - at least we won't forget then.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 13, 2017

Member

I didn't find where/how this is set up in matplotlib, doing a quick search.. can you give a quick link @QuLogic?

Member

megies commented Mar 13, 2017

I didn't find where/how this is set up in matplotlib, doing a quick search.. can you give a quick link @QuLogic?

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic Mar 14, 2017

Member

We have this setting, and I think you need to ask for it because it's in beta:
screenshot from 2017-03-14 17-12-39
As noted, it doesn't work on already-running tests, but maybe trying adding a 🎉 on travis-ci/beta-features#8 so they'll have more pressure to add it.

Member

QuLogic commented Mar 14, 2017

We have this setting, and I think you need to ask for it because it's in beta:
screenshot from 2017-03-14 17-12-39
As noted, it doesn't work on already-running tests, but maybe trying adding a 🎉 on travis-ci/beta-features#8 so they'll have more pressure to add it.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 15, 2017

Member

I'm not seeing that switch on our settings page.. I guess we can still switch once it's in public beta or out proper. Added the 🎉 in any case.. ;-)

Member

megies commented Mar 15, 2017

I'm not seeing that switch on our settings page.. I guess we can still switch once it's in public beta or out proper. Added the 🎉 in any case.. ;-)

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 22, 2017

Member

Auto cancellation is now live as a beta feature on Travis and I've switched it on for PRs in our Travis settings (not sure if it can be set via Travis yaml, which is always a bit more trasparent..).

Member

megies commented Mar 22, 2017

Auto cancellation is now live as a beta feature on Travis and I've switched it on for PRs in our Travis settings (not sure if it can be set via Travis yaml, which is always a bit more trasparent..).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment