New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more verbose TypeErrors in trace.__add__ #1725

Merged
merged 2 commits into from Mar 22, 2017

Conversation

Projects
None yet
3 participants
@ThomasLecocq
Contributor

ThomasLecocq commented Mar 20, 2017

What does this PR do?

Just adds some verbosity in the sanity checks done in the add method of traces.

Why was it initiated? Any relevant Issues?

It's soooooo frustrating to debug
TypeError("Data type differs")

PR Checklist

  • All tests still pass.
  • Significant changes have been added to CHANGELOG.txt (is this significant? don't think so)

@ThomasLecocq ThomasLecocq added this to the 1.1.0 milestone Mar 20, 2017

@megies megies added the .core label Mar 20, 2017

@ThomasLecocq

This comment has been minimized.

Show comment
Hide comment
@ThomasLecocq

ThomasLecocq Mar 20, 2017

Contributor

wtf? appveyor?

Contributor

ThomasLecocq commented Mar 20, 2017

wtf? appveyor?

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic Mar 20, 2017

Member

Change "matplotlib<2" to "matplotlib<1.9" since conda seems to think 2.0.0rc2 is not yet 2 and installs it.

Member

QuLogic commented Mar 20, 2017

Change "matplotlib<2" to "matplotlib<1.9" since conda seems to think 2.0.0rc2 is not yet 2 and installs it.

@ThomasLecocq

This comment has been minimized.

Show comment
Hide comment
@ThomasLecocq

ThomasLecocq Mar 21, 2017

Contributor

Change "matplotlib<2" to "matplotlib<1.9" since conda seems to think 2.0.0rc2 is not yet 2 and installs it.

I just based this on master, so you're saying we need to change master .appveyor.yml ?

Contributor

ThomasLecocq commented Mar 21, 2017

Change "matplotlib<2" to "matplotlib<1.9" since conda seems to think 2.0.0rc2 is not yet 2 and installs it.

I just based this on master, so you're saying we need to change master .appveyor.yml ?

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Mar 21, 2017

Member

Change "matplotlib<2" to "matplotlib<1.9" since conda seems to think 2.0.0rc2 is not yet 2 and installs it.

Ah.. right, and that's actually correct according to PEP 440

I just based this on master, so you're saying we need to change master .appveyor.yml ?

Since this PR is ready to merge already, you can just add it to this PR so the change will be in master within days.

Member

megies commented Mar 21, 2017

Change "matplotlib<2" to "matplotlib<1.9" since conda seems to think 2.0.0rc2 is not yet 2 and installs it.

Ah.. right, and that's actually correct according to PEP 440

I just based this on master, so you're saying we need to change master .appveyor.yml ?

Since this PR is ready to merge already, you can just add it to this PR so the change will be in master within days.

@megies

megies approved these changes Mar 21, 2017

Unless you want to add more to this PR it's good to merge..

@ThomasLecocq ThomasLecocq merged commit d9754b9 into obspy:master Mar 22, 2017

7 of 8 checks passed

codecov/changes 52 files have unexpected coverage changes not visible in diff.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 86.95% (+0.91%) compared to 727d059
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
docker-deb-buildbot Deb packaging and testing succeeded
Details
docker-testbot Docker tests succeeded
Details

@ThomasLecocq ThomasLecocq deleted the ThomasLecocq:verbose_trace_add branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment