Join GitHub today
Unify list of obspy dependencies (hard and soft) #1786
This PR proposes to finally manage the list of all ObsPy dependencies (hard and soft) in one unified place (together with all other important 'headers').
Since this file is used at install time (by setup.py) it can't have other obspy/future imports in it, so we an't use the existing
I'm actually a bit torn on this. I like the new separation in soft/hard dependencies. I'm not so sure I prefer moving the setup related things out of
setup.py - it is currently a bit long but most things are in one place at least. On the other hand the library names for example are already determined by
So I guess I'm not really sure what I'm trying to say here but I'd like to at least discuss this a bit.
I know, I'm torn too, but I don't see a different way to avoid duplication here, since
Yeah, we already have some stuff from
Sure, I definitely wanted to hear opinions/concerns about this one. But I feel it's a good thing to do, actually I think it clusters more of these "header" type stuff in one common place now.
E.g. replace (other instances of version comparison mostly at least already use list of integers provided by
from obspy.core.util import to_int_or_zero GDAL_VERSION_SUFFICIENT = [1, 7, 3] < list(map( to_int_or_zero, __gdal_version__.split(".")))
from pkg_resources import SetuptoolsVersion, get_distribution GDAL_VERSION_SUFFICIENT = ( SetuptoolsVersion('1.7.3') < get_distribution('gdal').parsed_version)
That way, all in-between version numbers (post/pre-release) etc would be taken into account properly by just handing over version comparison logic to