New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix current network test fails for release of 1.1.0 #1791

Merged
merged 4 commits into from Oct 8, 2017

Conversation

Projects
None yet
1 participant
@megies
Member

megies commented May 18, 2017

This PR is for fixing any currently relevant network test fails.

Going through Travis test results of current master (which test all modules), I see to issues:

  • arclink: miniseed record number change in trace.stats.mseed (e.g.here, across all systems)

Not entirely sure, but it looks like the record number in each trace's stats is now the record number for the current trace as opposed to the overall record number for the whole file? @krischer any change like this in io.mseed?

Error message using #1790 for pretty printing error message:

E           AssertionError: {u'processing': [u'ObsPy 1.0.3.post0+1221.g0c1721719c.obspy.pretty.print.stats:  [truncated]... != {u'processing': [u'ObsPy 1.0.3.post0+1221.g0c1721719c.obspy.pretty.print.stats:  [truncated]...
E           Diff is 2182 characters long. Set self.maxDiff to None to see it.
E             Differing items:
E               Expected:  mseed: AttribDict({u'record_length': 512, u'encoding': u'STEIM1', u'filesize': 30720, u'dataquality': u'D', u'number_of_records': 60, u'byteorder': u'>'})
E               Actual  :  mseed: AttribDict({u'record_length': 512, u'encoding': u'STEIM1', 'filesize': 30720, u'dataquality': u'D', u'number_of_records': 4, u'byteorder': u'>'})

Here's the file that gets downloaded in that test:
arclink.mseed.gz


+TESTS:ALL

@megies megies added this to the 1.1.0 milestone May 18, 2017

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Aug 11, 2017

Member

Rebased and force-pushed to see how network tests currently fare..

Member

megies commented Aug 11, 2017

Rebased and force-pushed to see how network tests currently fare..

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Oct 8, 2017

Member

For me locally, all network tests pass: http://tests.obspy.org/87732/

Member

megies commented Oct 8, 2017

For me locally, all network tests pass: http://tests.obspy.org/87732/

megies added some commits May 18, 2017

fix one strac neic test fail, caused by dynamic near-realtime request
returned data is sometimes one sample shorter than what would be
expected
fix and improve one seedlink test
apparently ring buffer was shortened on server side
adjust one arclink test, needed a change due to #1782
(tr.stats.mseed now holds number of records of respective trace, not
entire original mseed file)
@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Oct 8, 2017

Member

Network tests look good, only one fail I still see, in FDSN mass downloader (https://travis-ci.org/obspy/obspy/jobs/285180241#L3101). @krischer I'll leave that one to you, merging this.

Member

megies commented Oct 8, 2017

Network tests look good, only one fail I still see, in FDSN mass downloader (https://travis-ci.org/obspy/obspy/jobs/285180241#L3101). @krischer I'll leave that one to you, merging this.

@megies megies merged commit 94d5df0 into master Oct 8, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@megies megies deleted the fix_network_fails branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment