New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stationtxt write #1844

Merged
merged 3 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@nick-iris
Contributor

nick-iris commented Jul 17, 2017

This is a fix for the incorrect field being used as the Sensor Description in the "channel" level StationTXT output.

What does this PR do?

This PR includes a small update to the to StationTXT write method. Instead of writing the cha.sensor.type value for the channel level StationTXT SensorDescription, the method has been changed to correctly use cha.sensor.description.

Why was it initiated? Any relevant Issues?

For more details please see #1466 (comment)

@nick-iris nick-iris added the bug label Jul 17, 2017

@nick-iris nick-iris self-assigned this Jul 17, 2017

@nick-iris nick-iris requested a review from megies Jul 17, 2017

@megies megies added this to the 1.1.0 milestone Jul 18, 2017

@megies megies added the .io label Jul 18, 2017

@megies

megies approved these changes Jul 18, 2017

Looks good to me

@QuLogic QuLogic merged commit cedacb1 into master Jul 19, 2017

6 of 7 checks passed

docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5b057eb...d369a9f
Details
codecov/project 87.72% (+1.43%) compared to 5b057eb
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@QuLogic QuLogic deleted the fix_stationtxt_write branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment