New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the catchoutput errors #1885

Merged
merged 2 commits into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@ThomasLecocq
Contributor

ThomasLecocq commented Sep 11, 2017

  • solves the import of obspy from Jupyter Notebooks (#1866)
  • solves part of the catch output complexity (#1684)
ThomasLecocq ThomasLecocq
Fix the catchoutput errors
* one solves the import of obspy from Jupyter Notebooks (#1866)
* one solves part of the catch output complexity (#1684)
@ThomasLecocq

This comment has been minimized.

Show comment
Hide comment
@ThomasLecocq

ThomasLecocq Sep 11, 2017

Contributor

The jupyter error could have been caught if we were running jupyter notebook tests, e.g.

https://gist.github.com/lheagy/f216db7220713329eb3fc1c2cd3c7826#file-test_notebooks-py

Contributor

ThomasLecocq commented Sep 11, 2017

The jupyter error could have been caught if we were running jupyter notebook tests, e.g.

https://gist.github.com/lheagy/f216db7220713329eb3fc1c2cd3c7826#file-test_notebooks-py

changed printf(...) to unbuffered fprintf(stderr, ...)
although we can't catch C level output - at least now we can suppress it
in our test suite
@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Sep 13, 2017

Member

510baa4 seems to solve the output catching of GSE2 for me on all win archs (py2.7,3.4,3.5,3.6 each 32bit/64bit) - console as well as in eclipse

Member

barsch commented Sep 13, 2017

510baa4 seems to solve the output catching of GSE2 for me on all win archs (py2.7,3.4,3.5,3.6 each 32bit/64bit) - console as well as in eclipse

@barsch

This comment has been minimized.

Show comment
Hide comment
@barsch

barsch Sep 13, 2017

Member

concerning Jupyter test: don't know if this is really needed as it only applies for an edge case: windows/py3.6/running Jupyter ...if you want to add it, go ahead - but make it completely optional - I don't want Jupyter as a test dependency ;)

Member

barsch commented Sep 13, 2017

concerning Jupyter test: don't know if this is really needed as it only applies for an edge case: windows/py3.6/running Jupyter ...if you want to add it, go ahead - but make it completely optional - I don't want Jupyter as a test dependency ;)

@barsch

barsch approved these changes Sep 13, 2017

@ThomasLecocq

This comment has been minimized.

Show comment
Hide comment
@ThomasLecocq

ThomasLecocq Sep 13, 2017

Contributor

@barsch I'm always scared to push the button, so feel free to merge the PR :) you did most of the work, you deserve that "satisfaction" :)

Contributor

ThomasLecocq commented Sep 13, 2017

@barsch I'm always scared to push the button, so feel free to merge the PR :) you did most of the work, you deserve that "satisfaction" :)

@barsch barsch merged commit 91a3f29 into master Sep 14, 2017

3 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/patch 50% of diff hit (target 90%)
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.86% (+1.33%) compared to f9a8a3f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@barsch barsch deleted the fix_catch_output_new branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment