New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Arclink EOL message #1987

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@krischer
Member

krischer commented Nov 23, 2017

Arclink will "soon" be EOL. The EIDA management board asked us to raise a warning message when users are importing the Arclink client.

They'll come back to us with a concrete suggestion for this warning message.

Including this in the next bugfix release should be fine as it does not change behavior.

@krischer krischer added this to the 1.1.1 milestone Nov 6, 2017

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Nov 23, 2017

Member

This issue is now a PR raising a warning at arclink import time. Looks like this (not pretty but visible and it gets the job done):

screen shot 2017-11-23 at 17 37 02

That wording has been proposed by the EIDA management board.

Member

krischer commented Nov 23, 2017

This issue is now a PR raising a warning at arclink import time. Looks like this (not pretty but visible and it gets the job done):

screen shot 2017-11-23 at 17 37 02

That wording has been proposed by the EIDA management board.

@megies

megies approved these changes Nov 23, 2017

@megies megies merged commit 86a9113 into maintenance_1.1.x Nov 23, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@megies megies deleted the arclink-deprecation-warning branch Nov 23, 2017

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Nov 23, 2017

Member

Doesnt have a test, but I think it's really not necessary, as it's happening in main code block of __init__.py.

Member

megies commented Nov 23, 2017

Doesnt have a test, but I think it's really not necessary, as it's happening in main code block of __init__.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment