Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
io.reftek: switch internal representation of timestamps to integer #2038
..nanoseconds to avoid any floating point precision issues
What does this PR do?
Changes internal timestamp representation of Reftek130 packets from floats to integers.
Why was it initiated? Any relevant Issues?
referenced this pull request
Jan 8, 2018
Actually, it turns out the switch to internal integer nanoseconds time representations was not necessary to fix #2036 avoiding to sort the package list (which was done due to the package sequence rollover from 9999 to 0) would have been enough.
But nevertheless, using the integer representation seems safer, so I'll keep it this way.
I think there won't be a regression test for this.. the problem appears deep into the file and I didn't manage to reproduce the problem just cutting out those seemingly offending packages and slapping the original header packet onto them.. so having a regression test with a small test file would mean serious tinkering with the original huge file provided by the OP and no idea how long that would take me.