New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD: Let the channel and location restrictions override the priority lists #2041

Closed
wants to merge 1 commit into
base: maintenance_1.1.x
from

Conversation

Projects
None yet
2 participants
@paride
Member

paride commented Jan 9, 2018

What does this PR do?

This makes the code works as documented, that is: if the channel variable is set, then the channel_priorities list is ignored. The same goes for the location variable and location_priorities.

Why was it initiated? Any relevant Issues?

Fixes #1810 and #2031.

PR Checklist

  • Correct base branch selected? master for new fetures, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:clients.fdsn"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt.
Let the 'channel' and 'location' settings override the priority lists
This makes the code works as documented, that is: if the 'channel'
variable is set, then the 'channel_priorities' list is ignored. The
same goes for the 'location' variable and 'location_priorities'.

Fixes #1810.
Fixes #2031.
@paride

This comment has been minimized.

Show comment
Hide comment
@paride

paride Jan 9, 2018

Member

@megies This time I deleted my fork, forked the repository again, manually applied the patch, did a new commit, and finally created this new PR. Let's see.

Member

paride commented Jan 9, 2018

@megies This time I deleted my fork, forked the repository again, manually applied the patch, did a new commit, and finally created this new PR. Let's see.

@paride

This comment has been minimized.

Show comment
Hide comment
@paride

paride Jan 11, 2018

Member

@megies Lame question, sorry. How can I check if travis finally built this PR?

Member

paride commented Jan 11, 2018

@megies Lame question, sorry. How can I check if travis finally built this PR?

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Jan 12, 2018

Member

If you don't trust the PR check box at the end of the posts, you can check via API:
https://api.github.com/repos/obspy/obspy/commits/6f558fae425827a5aa249a9ca1165eb36f11ff95/statuses

..and there's no Travis to be found there.

I really have no fricking idea why Travis is not building your PRs. :-/

Member

megies commented Jan 12, 2018

If you don't trust the PR check box at the end of the posts, you can check via API:
https://api.github.com/repos/obspy/obspy/commits/6f558fae425827a5aa249a9ca1165eb36f11ff95/statuses

..and there's no Travis to be found there.

I really have no fricking idea why Travis is not building your PRs. :-/

@paride paride closed this Jan 12, 2018

@paride paride changed the title from Let the 'channel' and 'location' settings override the priority lists to MD: Let the channel and location restrictions override the priority lists Jan 12, 2018

@paride paride reopened this Jan 12, 2018

@paride paride closed this Jan 12, 2018

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Jan 12, 2018

Member

@paride I've added you to developers team, so you can push a branch to obspy/obspy directly. That really then should make Travis run your PR..

Member

megies commented Jan 12, 2018

@paride I've added you to developers team, so you can push a branch to obspy/obspy directly. That really then should make Travis run your PR..

@paride

This comment has been minimized.

Show comment
Hide comment
@paride

paride Jan 12, 2018

Member

Thanks @megies! In the meantime I reopened the pull request, this time changing its title a little bit and signing the commit (git commit -Ss). Let's see, out of curiosity, if Travis builds it. Otherwise I'll push a branch.

Member

paride commented Jan 12, 2018

Thanks @megies! In the meantime I reopened the pull request, this time changing its title a little bit and signing the commit (git commit -Ss). Let's see, out of curiosity, if Travis builds it. Otherwise I'll push a branch.

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Jan 12, 2018

Member

It's again not building it.. seem like Travis ignores your account.. ;-P

Member

megies commented Jan 12, 2018

It's again not building it.. seem like Travis ignores your account.. ;-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment