New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add support reading SC3ML v0.10; ResponseIIR & decimation on PAZ #2124

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Jollyfant
Contributor

Jollyfant commented Apr 26, 2018

This is a work in progress. Added code to read SC3ML version 0.10; also refactored some of the code.. for discussion see issue #2004

@Jollyfant Jollyfant self-assigned this Apr 26, 2018

@Jollyfant Jollyfant added this to the 1.2.0 milestone Apr 26, 2018

@megies

This comment has been minimized.

Member

megies commented May 14, 2018

@Jollyfant this doesn't look right and I think the reason is #2130. It looks like you were trying to rebase? If so, I would recommend to simply start from current master again and instead just cherry-pick that dozen commits manually. For me this used to be the simpler solution the last couple of times, as git was getting real confused during rebasing.

@Jollyfant

This comment has been minimized.

Contributor

Jollyfant commented May 14, 2018

Yeah I boned it.. I will redo it on current master

@Jollyfant

This comment has been minimized.

Contributor

Jollyfant commented May 14, 2018

Seems to be rebased on current master now 🎉 but I need to review this some time this week.. when are you pushing for 1.2.0?

@megies

This comment has been minimized.

Member

megies commented May 14, 2018

Seems to be rebased on current master now tada but I need to review this some time this week.. when are you pushing for 1.2.0?

There's still some time I think, a couple of weeks maybe. Dunno. Or longer if nobody pushes.

@Jollyfant

This comment has been minimized.

Contributor

Jollyfant commented May 14, 2018

Gotcha but meanwhile CI seems to be tripping up on something

@megies

This comment has been minimized.

Member

megies commented May 15, 2018

That fails unrelated, comes from a new numpy scipy choking up on sth in our code, see #2149

@megies

This comment has been minimized.

Member

megies commented May 18, 2018

Can you rebase on current master? Should get rid of unrelated fails..

@megies

This comment has been minimized.

Member

megies commented Nov 14, 2018

@Jollyfant as mentioned by Gempa staff on our users mailing list, there's also the responseFAP tag that needs to be implemented.

(should be easy to implement I think, as it's just a list of (amplitude, phase) tuples for given frequencies)

@megies

This comment has been minimized.

Member

megies commented Nov 14, 2018

@Jollyfant I added the responseFAP element and also properly made sensor/datalogger optional on channels.

I'll leave the rest to you, since you're most familiar with this submodule (please double-check etc). I'll add a test file if @yochaibh agrees we can use his file.

@megies

This comment has been minimized.

Member

megies commented Nov 14, 2018

@Jollyfant I felt free to rebase on current master.. so please update your local branches

Jollyfant and others added some commits May 14, 2018

sc3ml inventory reading: properly treat sensor/datalogger as optional
links to sensors/dataloggers in channel elements are specified as
optional in the schema. so properly handle the case that these can be
None in the lookup.
@Jollyfant

This comment has been minimized.

Contributor

Jollyfant commented Nov 14, 2018

Thanks @megies. I will put this on the to-do list and have a look at some clean-up for this module too. It could use some attention..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment