New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map plots for old mpl 1.2 #2139

Merged
merged 2 commits into from May 7, 2018

Conversation

Projects
None yet
1 participant
@megies
Member

megies commented May 7, 2018

What does this PR do?

Fix test fails on matplotlib 1.2, see e.g. http://tests.obspy.org/94743/#1

Why was it initiated? Any relevant Issues?

see #2089

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • All tests still pass.

@megies megies added this to the 1.1.1 milestone May 7, 2018

@megies

This comment has been minimized.

Member

megies commented May 7, 2018

This makes all plots work on mpl 1.2 / centos7, besides one image test that has bad tick formatting, but I cant really care that much about that ancient mpl on centos7.

@megies megies merged commit d287f1e into maintenance_1.1.x May 7, 2018

4 of 6 checks passed

codecov/patch 60% of diff hit (target 90%)
Details
docker-testbot Docker tests failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 88.07% (+1.33%) compared to ecacfd7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@megies megies deleted the fix_old_mpl12 branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment