New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs #2145

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@foobarbecue
Contributor

foobarbecue commented May 13, 2018

CONNNECTIONS --> CONNECTIONS

Fix typo
CONNNECTIONS --> CONNECTIONS
@megies

This comment has been minimized.

Member

megies commented May 14, 2018

Thanks for the typo fix @foobarbecue. Feel free to add yourself to list of contributors..

@megies

This comment has been minimized.

Member

megies commented May 14, 2018

Oh.. @foobarbecue I just noticed this should've been based on maintenance_1.1.x. Since you made your edit in the online editor, I'm assuming you probably don't want to do the rebasing yourself? Just let me know, I can also just cherry-pick your commit.

@megies megies added this to the 1.1.1 milestone May 14, 2018

@megies megies added the docs label May 14, 2018

@megies megies changed the title from Fix typo to Fix typo in docs May 15, 2018

@megies

This comment has been minimized.

Member

megies commented May 16, 2018

@foobarbecue I just cherry-picked your commit on maintenance branch and pushed, see 8e82052.

Thanks, and again just let me know if you want to be on the contributors list.

@megies megies closed this May 16, 2018

@foobarbecue

This comment has been minimized.

Contributor

foobarbecue commented May 19, 2018

Thanks @megies ! I don't feel I deserve contributors list for fixing a typo! Hopefully I will find time to make real contributions soon.

@megies

This comment has been minimized.

Member

megies commented May 22, 2018

Alright, your call. Looking forward to more contributions then, @foobarbecue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment