New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more location codes to the default priority list #2159

Merged
merged 4 commits into from May 24, 2018

Conversation

Projects
None yet
2 participants
@krischer
Member

krischer commented May 24, 2018

See discussion in #2155. Fixes #2155.

@krischer krischer added this to the 1.2.0 milestone May 24, 2018

@krischer krischer requested a review from megies May 24, 2018

@megies

This comment has been minimized.

Member

megies commented May 24, 2018

If you can be bothered, I think it would be really nice to have a warning message when stations are dropped because they have data but all channels are dropped due to location priorities (esp. when the default is in effect). Not sure how complicated that would be to add..?

@megies

megies approved these changes May 24, 2018

See comment above, but otherwise looks good to me!

krischer added some commits May 24, 2018

@krischer

This comment has been minimized.

Member

krischer commented May 24, 2018

If you can be bothered, I think it would be really nice to have a warning message when stations are dropped because they have data but all channels are dropped due to location priorities (esp. when the default is in effect). Not sure how complicated that would be to add..?

Good idea. I added some more commits to this PR to implement it.

@krischer

This comment has been minimized.

Member

krischer commented May 24, 2018

Test failures in CI are unrelated (and weird - does someone understand them?). Merging.

@krischer krischer merged commit 8fb891b into obspy:master May 24, 2018

2 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
docker-testbot Docker tests failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krischer krischer deleted the krischer:mdl-location-priorities branch May 24, 2018

@megies

This comment has been minimized.

Member

megies commented May 25, 2018

Thanks for adding that message, I think this is in really good shape now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment