Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obspy-scan: allow fnmatch wildcards when selecting specific SEED IDs during plotting #2227

Merged
merged 2 commits into from Mar 19, 2019

Conversation

2 participants
@megies
Copy link
Member

megies commented Oct 5, 2018

What does this PR do?

Allow fnmatch wildcards when selecting specific SEED IDs during plotting so one can e.g. select only "[EH]H*" channels for a plot after scanning an SDS tree.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

Just needs a short test basically..

@megies megies added the enhancement label Oct 5, 2018

@megies megies added this to the 1.2.0 milestone Oct 5, 2018

@megies megies self-assigned this Oct 5, 2018

@krischer krischer added this to Free for the Taking in Release 1.2.0 Feb 14, 2019

@megies megies force-pushed the scan_wildcard_selector branch from b103d78 to f190c35 Feb 14, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 14, 2019

Rebased on current master and force-pushed so that we have fresh CI results tomorrow.

@ThomasLecocq ThomasLecocq moved this from Free for the Taking to In Progress in Release 1.2.0 Feb 15, 2019

@ThomasLecocq

This comment has been minimized.

Copy link
Contributor

ThomasLecocq commented Feb 15, 2019

Where is the aaaamaaaazing test case?

@megies megies force-pushed the scan_wildcard_selector branch from f190c35 to 88ffbf8 Mar 15, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Mar 15, 2019

Should be good now, lets wait for CI

@megies megies moved this from In Progress to Waiting on CI in Release 1.2.0 Mar 15, 2019

@megies megies force-pushed the scan_wildcard_selector branch from 88ffbf8 to 27796bc Mar 15, 2019

@megies megies force-pushed the scan_wildcard_selector branch from 27796bc to 0467160 Mar 15, 2019

obspy-scan: allow fnmatch wildcards when selecting specific SEED IDs
during plotting

so one can e.g. select all "[EH]H*" channels for a plot of all scanned
data

@megies megies force-pushed the scan_wildcard_selector branch from 0467160 to ba61aad Mar 16, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Mar 19, 2019

Test fail unrelated.

@megies megies merged commit 1a71707 into master Mar 19, 2019

2 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@megies megies deleted the scan_wildcard_selector branch Mar 19, 2019

@megies megies moved this from Waiting on CI to Done in Release 1.2.0 Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.