New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning capture fix #2234

Merged
merged 3 commits into from Oct 15, 2018

Conversation

Projects
None yet
4 participants
@d-chambers
Member

d-chambers commented Oct 8, 2018

What does this PR do?

fixes #2233 where the internal testing utility for capturing warnings reliably across python versions did not work for warnings.warn.

Why was it initiated? Any relevant Issues?

#2233

Note: since this a small change to an internal tool I decided to base of master. Happy to change it if needed.

Show resolved Hide resolved obspy/core/util/testing.py Outdated

@megies megies added this to the 1.2.0 milestone Oct 9, 2018

@d-chambers d-chambers added the testing label Oct 10, 2018

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Oct 12, 2018

Member

I rebased and force-pushed to get rid of the merge commit.

Member

megies commented Oct 12, 2018

I rebased and force-pushed to get rid of the merge commit.

d-chambers added some commits Oct 8, 2018

@d-chambers

This comment has been minimized.

Show comment
Hide comment
@d-chambers

d-chambers Oct 12, 2018

Member

Thanks @megies,
I forgot to rebase rather than pull to avoid that extra commit. Sorry about that.

Member

d-chambers commented Oct 12, 2018

Thanks @megies,
I forgot to rebase rather than pull to avoid that extra commit. Sorry about that.

@krischer

This comment has been minimized.

Show comment
Hide comment
@krischer

krischer Oct 15, 2018

Member

Thanks for this!

Member

krischer commented Oct 15, 2018

Thanks for this!

@krischer krischer merged commit 4f66b39 into master Oct 15, 2018

1 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details

@krischer krischer deleted the warning_capture_fix branch Oct 15, 2018

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Oct 18, 2018

Member

I forgot to rebase rather than pull to avoid that extra commit. Sorry about that.

no worries, quick fix

Member

megies commented Oct 18, 2018

I forgot to rebase rather than pull to avoid that extra commit. Sorry about that.

no worries, quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment