New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPSD: nicer error msg for "ringlaser" with complex metadata #2243

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
1 participant
@megies
Member

megies commented Oct 11, 2018

What does this PR do?

Fixes #2240 by having a nicer error message.

Why was it initiated? Any relevant Issues?

#2240

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@megies megies added the .signal label Oct 11, 2018

@megies megies added this to the 1.2.0 milestone Oct 11, 2018

@megies

This comment has been minimized.

Show comment
Hide comment
@megies

megies Oct 15, 2018

Member

Fails are unrelated.

Member

megies commented Oct 15, 2018

Fails are unrelated.

@megies megies merged commit 771d75e into master Oct 15, 2018

1 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details

@megies megies deleted the ppsd_ringlaser_error_msg branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment