Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
PPSD: fix period_lim with xaxis_frequency=True #2246
What does this PR do?
Why was it initiated? Any relevant Issues?
Fixes #2245. Since this changes behavior a bit, I decided to base this on master. Doesnt matter too much anyway, since plot ranges can easily be adjusted post-plotting going via matplotlib commands anyway.
@megies the images fail to compare in the tests, but I guess this is normal since the documented behaviour was not what was plotted afterwards? e.g. the test requires
while it is now, thanks to your changes:
Should you also update the reference images then ?
the windows' evalresp is not related to this.
moved this from Waiting on CI
to Waiting for final manual validation by Core Dev
in Release 1.2.0
Feb 15, 2019
I'll try again with mpl 2.2.2. Maybe I have to up some tolerances if it's still failing..
Btw.. I think we should weed out image tests. Most special case testing should be done by checking the