Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPSD: fix period_lim with xaxis_frequency=True #2246

Merged
merged 3 commits into from Mar 15, 2019

Conversation

2 participants
@megies
Copy link
Member

megies commented Oct 18, 2018

What does this PR do?

Makes PPSD.plot(..., period_lim=(...), xaxis_frequency=True) work as documented in docstring.

Why was it initiated? Any relevant Issues?

Fixes #2245. Since this changes behavior a bit, I decided to base this on master. Doesnt matter too much anyway, since plot ranges can easily be adjusted post-plotting going via matplotlib commands anyway.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@megies megies added this to the 1.2.0 milestone Oct 18, 2018

@megies megies force-pushed the fix_ppsd_freq_period_lim branch from ae46537 to 381623a Oct 18, 2018

@krischer krischer added this to Free for the Taking in Release 1.2.0 Feb 14, 2019

@megies megies force-pushed the fix_ppsd_freq_period_lim branch from 381623a to c6cae13 Feb 14, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 14, 2019

Rebased on current master and force-pushed so that we have fresh CI results tomorrow.

@ThomasLecocq

This comment has been minimized.

Copy link
Contributor

ThomasLecocq commented Feb 15, 2019

@megies the images fail to compare in the tests, but I guess this is normal since the documented behaviour was not what was plotted afterwards? e.g. the test requires period_lim=(0.01, 50) which was not respected in the reference img:
https://i.imgur.com/50BopGl.png

while it is now, thanks to your changes:
https://i.imgur.com/ktvUy8z.png

Should you also update the reference images then ?

the windows' evalresp is not related to this.

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 15, 2019

Should you also update the reference images then ?

Yep, you're right, nice catch!

@megies megies moved this from Free for the Taking to Waiting on CI in Release 1.2.0 Feb 15, 2019

@ThomasLecocq ThomasLecocq moved this from Waiting on CI to Waiting for final manual validation by Core Dev in Release 1.2.0 Feb 15, 2019

@ThomasLecocq ThomasLecocq moved this from Waiting for final manual validation by Core Dev to Waiting on CI in Release 1.2.0 Feb 15, 2019

@ThomasLecocq

This comment has been minimized.

Copy link
Contributor

ThomasLecocq commented Feb 17, 2019

@megies still the issue with img generated with mp 2.0.2

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 18, 2019

I'll try again with mpl 2.2.2. Maybe I have to up some tolerances if it's still failing..

Btw.. I think we should weed out image tests. Most special case testing should be done by checking the Axes objects etc. Like this test is only making sure that changing the x axis label/datalim works, so we shouldn't have a designated image test for it in the first place, I guess.

megies added some commits Oct 18, 2018

@megies megies force-pushed the fix_ppsd_freq_period_lim branch from 5d418a5 to f9c4cbb Feb 19, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Mar 15, 2019

OK CI passed, so merging!

@megies megies merged commit cf74a53 into master Mar 15, 2019

5 of 6 checks passed

docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 87.92% (+1.06%) compared to 0bc9464
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@megies megies deleted the fix_ppsd_freq_period_lim branch Mar 15, 2019

@megies megies moved this from Waiting on CI to Done in Release 1.2.0 Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.