New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read FIR coeff even if multiple whitespaces #2259

wants to merge 4 commits into
base: maintenance_1.1.x


None yet
2 participants

thefroid commented Nov 8, 2018

What does this PR do?

Fix a bug in the module read_inventory when a SC3ML file is given:
-Read the FIR coefficients even if multiple whitespaces are present between the coeffcients
in the sc3ml file.

Why was it initiated? Any relevant Issues?

Unable to read the instrumental response of a raspberryshake3d (version5) with the module read_inventory.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

megies approved these changes Nov 12, 2018

Looks good to me, thanks @thefroid!

(No idea what XML schema thinks about multiple spaces in lists but I guess it can't hurt here anyway..)

@megies megies added this to the 1.1.1 milestone Nov 12, 2018

@megies megies added the .io label Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment