Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trimming waveforms after fetching from FDSN Client #2298

Merged
merged 5 commits into from Feb 20, 2019

Conversation

2 participants
@LMurrayBergquist
Copy link
Contributor

LMurrayBergquist commented Jan 29, 2019

What does this PR do?

Fixes trimming of waveforms fetched from FDSN clients to make sure start/endtimes match what user requested and no additional data is present around given time span.

Why was it initiated? Any relevant Issues?

Fixes #1887

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
Show resolved Hide resolved obspy/clients/fdsn/client.py Outdated
@megies

This comment has been minimized.

Copy link
Member

megies commented Jan 30, 2019

+TESTS:clients.fdsn so that CI runs FDSN tests

@megies

This comment has been minimized.

Copy link
Member

megies commented Feb 18, 2019

I'll change the base branch to master soonish..

@megies megies added this to the 1.2.0 milestone Feb 18, 2019

@megies megies changed the base branch from maintenance_1.1.x to master Feb 18, 2019

@megies megies added this to In Progress in Release 1.2.0 Feb 18, 2019

LMurrayBergquist and others added some commits Jan 29, 2019

Fixing bug #1887 in get_waveforms
Trims traces to start and end times.

@megies megies force-pushed the LMurrayBergquist:fix_1887 branch from 77629d9 to c89e5d8 Feb 20, 2019

@megies megies moved this from In Progress to Waiting on CI in Release 1.2.0 Feb 20, 2019

@megies

This comment has been minimized.

Copy link
Member

megies commented Feb 20, 2019

@LMurrayBergquist I force-pushed to your fork, so your local branch got out of sync (mostly because a rebase was necessary). But it's OK, there should be no more work needed on this, so just ignore.

@LMurrayBergquist

This comment has been minimized.

Copy link
Contributor Author

LMurrayBergquist commented Feb 20, 2019

Ok, thanks for the heads up!

@megies

This comment has been minimized.

Copy link
Member

megies commented Feb 20, 2019

Test fails are unrelated, gonna merge after a minor refactor

@megies megies merged commit ce2f41e into obspy:master Feb 20, 2019

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@megies megies moved this from Waiting on CI to Done in Release 1.2.0 Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.