New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.shapefile: support for writing extra fields with Inventory objects #2305

Merged
merged 3 commits into from Feb 15, 2019

Conversation

1 participant
@megies
Copy link
Member

megies commented Feb 7, 2019

What does this PR do?

Adds support for writing extra fields also for inventory objects, similar to what is already possible for catalogs. See #2012

Why was it initiated? Any relevant Issues?

--

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@megies megies added this to the 1.2.0 milestone Feb 7, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 7, 2019

+DOCS

@krischer krischer added this to In Progress in Release 1.2.0 Feb 14, 2019

megies added some commits Feb 7, 2019

@megies megies force-pushed the megies:shapefile_inv_extra_fields branch from b0be35a to df9e108 Feb 14, 2019

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 14, 2019

Rebased on current master and force-pushed so that we have fresh CI results tomorrow.

@megies

This comment has been minimized.

Copy link
Member Author

megies commented Feb 15, 2019

Ready to merge I think.

@megies megies merged commit c22ea45 into obspy:master Feb 15, 2019

5 of 7 checks passed

docs-buildbot Build succeeded, but there are warnings/errors:
Details
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 87.59% (+0.66%) compared to daeffef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@megies megies moved this from In Progress to Done in Release 1.2.0 Feb 15, 2019

@megies megies deleted the megies:shapefile_inv_extra_fields branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment