Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2222 #2324

Merged
merged 3 commits into from Feb 15, 2019

Conversation

3 participants
@d-chambers
Copy link
Member

d-chambers commented Feb 14, 2019

What does this PR do?

Fixes #2222

Why was it initiated? Any relevant Issues?

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@d-chambers d-chambers added this to the 1.2.0 milestone Feb 14, 2019

@d-chambers d-chambers added this to In Progress in Release 1.2.0 Feb 14, 2019

@d-chambers d-chambers moved this from In Progress to Waiting for Review in Release 1.2.0 Feb 14, 2019

@megies megies force-pushed the fix_2222 branch from c041568 to 6511ba5 Feb 14, 2019

@megies

This comment has been minimized.

Copy link
Member

megies commented Feb 14, 2019

Rebased on current master and force-pushed so that we have fresh CI results tomorrow.

d-chambers added some commits Feb 14, 2019

@megies megies force-pushed the fix_2222 branch from 6511ba5 to 804f0f2 Feb 14, 2019

@ThomasLecocq
Copy link
Contributor

ThomasLecocq left a comment

seem all OK for me, all tests pass

@megies shouldn't it be in maintenance ?

@megies

This comment has been minimized.

Copy link
Member

megies commented Feb 15, 2019

@megies shouldn't it be in maintenance ?

Nah, #2232 was also done against master, so it's good

@megies

megies approved these changes Feb 15, 2019

Copy link
Member

megies left a comment

I'll add changelog and then good to go

@megies megies merged commit d9eb091 into master Feb 15, 2019

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@megies megies deleted the fix_2222 branch Feb 15, 2019

@megies megies moved this from Waiting for Review to Done in Release 1.2.0 Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.