Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency version number comparison in tests #2327

merged 1 commit into from Feb 16, 2019


1 participant
Copy link

megies commented Feb 15, 2019

What does this PR do?

Fix execution of core test suite on Python 3 when basemap is not installed.

Why was it initiated? Any relevant Issues?


PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
fix dependency version number comparison with >= etc.
just use [] instead of None for missing dependencies internally. that
way all comparison operators work properly always

No idea why unittest skipIf wasn't skipping due to the (not
BASEMAP_VERSION) clause before hitting this on Python3 exclusively


@megies megies added the testing label Feb 15, 2019

@megies megies added this to the 1.1.1 milestone Feb 15, 2019

@megies megies added this to Waiting for Review in Release 1.1.1 Feb 15, 2019

@megies megies merged commit dbf6afd into maintenance_1.1.x Feb 16, 2019

4 of 5 checks passed

docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@megies megies deleted the fix_dep_version_comparison branch Feb 16, 2019

@megies megies moved this from Waiting for Review to Done in Release 1.1.1 Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.