Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: dont advertize Stream.attach_response() in API docs landing page #2331

merged 1 commit into from Feb 19, 2019


Copy link

megies commented Feb 15, 2019

What does this PR do?

Removes Stream.attach_response() being advertized in API docs front page.


Why was it initiated? Any relevant Issues?


PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
@megies megies added the docs label Feb 15, 2019
@megies megies added this to the 1.2.0 milestone Feb 15, 2019
@megies megies added this to Waiting for Review in Release 1.2.0 Feb 15, 2019
@megies megies moved this from Waiting for Review to Waiting on CI in Release 1.2.0 Feb 15, 2019

This comment has been minimized.

Copy link
Member Author

megies commented Feb 19, 2019

Looks good, merging.

@megies megies merged commit 19826bb into master Feb 19, 2019
2 of 6 checks passed
2 of 6 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
continuous-integration/appveyor/pr AppVeyor build failed
docs-buildbot Build succeeded, but there are warnings/errors:
docker-testbot docker testbot results not available yet
ci/circleci Your tests passed on CircleCI!
continuous-integration/travis-ci/pr The Travis CI build passed
@megies megies deleted the dont_advertize_attach_response branch Feb 19, 2019
@megies megies moved this from Waiting on CI to Done in Release 1.2.0 Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.