Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2339 #2340

Merged
merged 3 commits into from Mar 1, 2019

Conversation

3 participants
@d-chambers
Copy link
Member

d-chambers commented Feb 26, 2019

What does this PR do?

A simple and quick fix to issue #2339.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

d-chambers added some commits Feb 26, 2019

@megies megies added this to the 1.2.0 milestone Feb 27, 2019

@megies megies added this to Waiting for Review in Release 1.2.0 Mar 1, 2019

@krischer krischer added the .io.quakeml label Mar 1, 2019

@krischer

This comment has been minimized.

Copy link
Member

krischer commented Mar 1, 2019

Thanks for this! I added a changelog entry. I guess it is questionable if we want to write the empty event description tag in the first place but I agree that the ability to round-trip to QuakeML and back has a higher priority here.

@krischer krischer merged commit 74504e7 into master Mar 1, 2019

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@krischer krischer deleted the fix_2339 branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.