Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to the recalculate_overall_sensitivity() method #2343

Merged
merged 2 commits into from Mar 1, 2019

Conversation

2 participants
@krischer
Copy link
Member

commented Mar 1, 2019

Also fixes #2338.

@krischer krischer added this to the 1.2.0 milestone Mar 1, 2019

krischer added some commits Mar 1, 2019

@krischer krischer force-pushed the more-lenient-recalculate-sensitivity branch from 5d502cf to 1600dda Mar 1, 2019

@krischer krischer requested a review from trichter Mar 1, 2019

@krischer krischer added this to Waiting for Review in Release 1.2.0 Mar 1, 2019

@trichter
Copy link
Member

left a comment

That fixes the issue.

Maybe use self.assertAlmostEqual instead of np.testing.assert_allclose? I guess it doesn't matter.

@krischer

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

Maybe use self.assertAlmostEqual instead of np.testing.assert_allclose? I guess it doesn't matter.

You are right but I think we have plans to eventually move to pytest at which point self.assertAlmostEqual would no longer be available. I'll just leave it as it is for now.

@krischer krischer merged commit 5ed796d into master Mar 1, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 87.97% (+1.25%) compared to 74504e7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krischer krischer deleted the more-lenient-recalculate-sensitivity branch Mar 1, 2019

@krischer krischer moved this from Waiting for Review to Done in Release 1.2.0 Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.