Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly closing the thread pool for the fdsn routing client #2344

Merged
merged 2 commits into from Mar 15, 2019

Conversation

2 participants
@krischer
Copy link
Member

commented Mar 1, 2019

Fixes #2342 (I hope).

@megies

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

restarting appveyor

@megies megies moved this from In Progress to Waiting on CI in Release 1.2.0 Mar 7, 2019

@megies

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

CI didn't run FDSN tests.. but I'll merge this now anyway, looks sane and if we run into problems we can fix them later. We need to run network tests before releasing anyway

@megies megies merged commit 5ef2350 into master Mar 15, 2019

0 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@megies megies deleted the close-threads-routing branch Mar 15, 2019

@megies megies moved this from Waiting on CI to Done in Release 1.2.0 Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.